Subject: Re: IMAP-2002e pop3.c bug (fwd)

From: Mark Crispin <[email-masked]>
Date: Wed, 24 Sep 2003 11:10:31 -0700 (PDT)

> Some POP3 server just closed connection without ERR response when authentication failed.
>
> --- pop3.c.orig	Wed Sep 24 14:24:50 2003
> +++ pop3.c	Wed Sep 24 14:25:14 2003
> @@ -638,7 +638,7 @@
>    }
>  				/* abort requested */
>    else ret = net_sout (LOCAL->netstream,"*\015\012",3);
> -  pop3_reply (stream);		/* get response */
> +  if ( !pop3_reply (stream) ) ret = NIL;		/* get response */
>    return ret;
>  }

That patch can't be right; it treats "disconnected" the same as "password
failed" and thus prevents password retries.

Are you trying to prevent a SEGV at pop3_challenge()?  If so, the correct
fix is to add a test for LOCAL->response being NIL in that function.

-- Mark --

http://staff.washington.edu/mrc
Science does not emerge from voting, party politics, or public debate.
Si vis pacem, para bellum.