Subject: bug in "X eXtraHdr" command

From: Eduardo Chappa <[email-masked]>
Date: Thu, 17 Jul 2003 12:45:27 -0700 (PDT)

Hello,

  A bug which sends Pine into an infinite loop is present in the "X
eXtraHdr" command available in the "Roles/Filters/Scores/Other rules"
screens. The bug can be reproduced by adding an extra header when the
"BdyText pattern" line is the first line in the screen.

   A patch to fix this bug can be downloaded from my web page.

  Aside question: Why is there a "O Other Cmds" option in the menu for the
"Nickname" in this screen?. I found a bug related to that, but I can't
reproduce it now :(.

Eduardo
http://www.math.washington.edu/~chappa/pine/
-- 
-----------------------------------------------------------------
 For information about this mailing list, and its archives, see: 
 http://www.washington.edu/pine/pine-info/
-----------------------------------------------------------------

---

From: Steve Hubert <[email-masked]>
Date: Fri, 18 Jul 2003 10:34:22 -0700 (PDT)

>    A patch to fix this bug can be downloaded from my web page.

Thanks, Eduardo, your patch looks right to us, too.

> "Nickname" in this screen?. I found a bug related to that, but I can't

It shouldn't be there but I can't see any bug that it would cause.
Pressing O should cause it to set km->which to (1 % 1), which is zero.
But, as you know, the fix is

*** other.c.old	Fri Jul 18 10:32:27 2003
--- other.c.new	Fri Jul 18 10:32:51 2003
***************
*** 764,770 ****

  static struct key config_role_keys[] =
         {HELP_MENU,
! 	OTHER_MENU,
  	EXIT_SETUP_MENU,
  	{"C", "[Change Val]", {MC_EDIT,3,{'c',ctrl('M'),ctrl('J')}}, KS_NONE},
  	PREV_MENU,
--- 764,770 ----

  static struct key config_role_keys[] =
         {HELP_MENU,
! 	NULL_MENU,
  	EXIT_SETUP_MENU,
  	{"C", "[Change Val]", {MC_EDIT,3,{'c',ctrl('M'),ctrl('J')}}, KS_NONE},
  	PREV_MENU,

Thanks!
Steve

---

From: Eduardo Chappa <[email-masked]>
Date: Fri, 18 Jul 2003 12:45:23 -0700 (PDT)

*** Steve Hubert ([email-masked]) wrote in the pine-info list today:

:) On Thu, 17 Jul 2003, Eduardo Chappa wrote:
:)
:) >   Aside question: Why is there a "O Other Cmds" option in the menu
:) > for the "Nickname" in this screen?. I found a bug related to that,
:) > but I can't reproduce it now :(.
:)
:) It shouldn't be there but I can't see any bug that it would cause.
:) Pressing O should cause it to set km->which to (1 % 1), which is zero.
:) But, as you know, the fix is

Thank you Steve. I appreciate the patch. After several trials, I figured
out that the "bug" was not in Pine4.56, but in 4.44 (one can add an extra
header in the Nickname line). I did not remember that I had run an old
version of Pine before I wrote that line. Sorry for the false alarm.

Eduardo