Subject: 4.4x + maildir patch - unable to save to mbox

From: Jozef Hitzinger <[email-masked]>
Date: Tue, 4 Dec 2001 15:10:04 +0100 (CET)

Hello,

I use pine for quite long time now, and because I use qmail and Maiildir
on my system, I also maintain the page for maildir pine patches
(http://hico.fphil.uniba.sk/pine-patches.html). Several people reported
problem with using the maildir patch with current (4.4x) pine.

Up to 4.33, after applying the patch only Inbox was in Maildir format, and
if you (S)aved mail from it to another folder, it used mbox driver for it.
That made sense, at least to me (won't go into Maildir vs mbox debate).

In 4.4x this is no longer the case, if Inbox is maildir, and message is
(S)aved, it creates mbox ok, but tries to use maildir driver to write to
it. That fails, of course. Seems as a pine bug to me.

Now the question: I've identified the routine save() in mailcmd.c as the
source of our problems. If I comment out the following code

    /*
     * If any of the messages have exceptional attachment handling
     * we have to fall thru below to do the APPEND by hand...
     */
    if(!msgno_any_deletedparts(stream, msgmap)){
        /*
         * Compare the current stream (the save's source) and the stream
         * the destination folder will need...
         */
      context_apply(tmp, context, save_folder, sizeof(tmp));
        save_stream = (stream->dtb->flags & DR_LOCAL) && !IS_REMOTE(tmp) ?
        stream : context_same_stream(context, save_folder, stream);
    }

at the start of this function, so that save_stream remains NULL, it
appears to work as in 4.33. Can anybody help me understand what is this
code trying to do, and why it gives us these problems? Or at least confirm
that commenting this out will not break other things ..

Thanks,
-- 
jozef  :-)

-- 
-----------------------------------------------------------------
 For information about this mailing list, and its archives, see: 
 http://www.washington.edu/pine/pine-info/
-----------------------------------------------------------------