Subject: Bug in pine4.31/imap/src/osdep/unix/auth_ssl.c

From: "Mike A. Harris" <[email-masked]>
Date: Tue, 12 Dec 2000 05:26:03 -0500 (EST)

The file pine4.31/imap/src/osdep/unix/auth_ssl.c contains an
MSDOS CRLF character (^L) or 0x0c embedded in it just immediately
after the opening comment.  Most likely someone edited this file
with an MSDOS/Windows editor and committed the change.  ;o(

I wonder how many more files may be affected..

Using the Linux "joe" editor, the CTRL-L character stands out
clearly.

-- 
Mike A. Harris                  Mailing address:
OS Systems Engineer             190 Pittsburgh Ave.
Red Hat Inc.                    Sault Ste. Marie,
(705)949-2136                   Ontario, Canada, P6C 5B3

-- 
-----------------------------------------------------------------
 For information about this mailing list, and its archives, see: 
 http://www.washington.edu/pine/pine-info/
-----------------------------------------------------------------

---

From: "Mike A. Harris" <[email-masked]>
Date: Tue, 12 Dec 2000 05:31:43 -0500 (EST)

>Using the Linux "joe" editor, the CTRL-L character stands out

I hate to reply to myself, but...  I just examined numerous files
and many files in the PINE sources contain a single CRLF after
the initial comment in the file.  Not all files, but a lot of
them.  Looks like someone used Windows "mass search and replace"
type of software of some sort.

---

From: Steffen Kaiser <[email-masked]>
Date: Tue, 12 Dec 2000 13:10:09 +0100 (CET)

> type of software of some sort.

Hmm, ^L is not a CRLF, as you can see in an ASCII spec:
CR == 0xd '\r' ^M "Carrage Return"
LF == 0xa '\n' ^J "Line Feed"
FF == 0xc '\f' ^L "Form Feed"

It's common practice for people, who print C files by, say, "cat source.c
>/dev/lp" or "copy source.c LPT", to include such characters to format the
output.
The fact that it appears "just immediately after the opening comment"
supports this idea, because a FF at this position will cause that:
1) the initial comment stands on the very first page alone, and
2) the real code starts on its own page.
Some source code formatters add a FF behind each function therefore.

The C spec defines that any control character except \n is interpreted as
whitespace/blank except in string constants.

Bye,

-- 

Steffen Kaiser

---

From: "Mike A. Harris" <[email-masked]>
Date: Tue, 12 Dec 2000 09:52:46 -0500 (EST)

>FF == 0xc '\f' ^L "Form Feed"

<bangs head on keyboard> duh..  brain fart on my part there.  ;o)
I don't know how I mixed up FF and CR.  I guess I jumped to
conclusion without thinking too clearly there.

>>/dev/lp" or "copy source.c LPT", to include such characters to format the

Hmmm.. I never encountered that before.

>Some source code formatters add a FF behind each function therefore.

Yes, it appears that way.

>whitespace/blank except in string constants.

Having never in 7 years encountered FF's in C source you must
understand my willingness to blame my failed build on them.  ;o)

Funny enough, the build succeeded after removing the initial one
I found...  I'll have to look at it more closely in case I did a
double whammy on myself...

Thanks for the info.
TTYL

----------------------------------------------------------------------
      Mike A. Harris  -  Linux advocate  -  Open source advocate
          This message is copyright 2000, all rights reserved.
  Views expressed are my own, not necessarily shared by my employer.
----------------------------------------------------------------------

[Mike A. Harris Linux tip #1 - 50 line mode]
Is the 80x25 line screen too small for you?  If you want more screen real
estate, you can set 50 column mode by editing your /etc/lilo.conf file, and 
adding a new line with "vga=ext" to the global section near the top.  Save
and exit, then run "lilo".  Next time you boot, you'll have a nice big 80x50 
screen.