Subject: Pine Reply Bug?

From: Rocky Giannini <[email-masked]>
Date: Thu, 7 Oct 1993 13:48:07 -0400 (EDT)

When Pine 3.85 was first released, I posted a message stating that we
were consistently getting core dumps when replying to messages from certain 
sites.

We have since narrowed the problem down.  It appears that pine was having
trouble replying to messages that did not have a Message-Id header.
Message-Id header generation was (by default) turned off in our sendmail.cf. 
It appears that pine generates it's own Message-Id header so that if
a pine user received a message sent with pine the reply command worked fine.
However messages generated with any other mailer (mail, mailx, elm 
etc...) caused pine to dump core when the reply command was issued.

We have since cleared up this problem by uncommenting the line
"H?M?Message-Id: <$t.$i@$j>"  in our sendmail.cf file.  Now all messages
that pass through our system get a Message-Id, but I'm wondering if
this is a bug in the latest version of pine, or if our system was configured
incorrectly to begin with.  We have never had problems with any other mailers
or previous versions of pine.

-- 
Rocky Giannini
UMUC Unix and VMS Systems

---

From: Steve Hubert <[email-masked]>
Date: Thu, 7 Oct 1993 11:29:37 -0700 (PDT)

This has been fixed for 3.86.  Thanks.

Steve Hubert <[email-masked]>
Networks and Distributed Computing, Univ. of Washington, Seattle

---

From: David L Miller <[email-masked]>
Date: Thu, 7 Oct 1993 11:41:23 -0700 (PDT)

This is fixed in Pine 3.86.  Unless a major bug shows up in the next few 
minutes, we will begin packaging this afternoon...

|\ |  |\/|  David L. Miller    [email-masked]  (206) 685-6240
|/ |_ |  |  Software Engineer, Pine Development Team   (206) 685-4045 (FAX)
University of Washington, Networks & Distributed Computing
4545 15th Ave NE, Seattle WA 98105, USA

---

From: Barry Cornelius <[email-masked]>
Date: Thu, 7 Oct 1993 19:51:32 +0100 (BST)

On Thu, 7 Oct 1993, Rocky Giannini wrote:

> [stuff deleted]

I have noticed this too.

If you reply to a message with no Message-ID line, with 3.85 compiled for 
HP-UX 8.07, Pine will generate the following line in the reply: 
   In-Reply-To: 
With SunOS 4.1.x, Pine 3.85 will generate the following line in the reply:
   In-Reply-To: (null)
However, with SunOS 5.2, Pine 3.85 will crash if an attempt is made to
reply to a message that has no Message-ID line. 

The problem lies in the function generate_reply_to in the file
pine/reply.c.  This function attempts to use sprintf on a pointer which I
believe is NULL when replying to a message with no Message-ID line.

The following patch solves the problem.  With this patch, the In-Reply-To
line is not generated (when replying to a message with no Message-ID
line). 

*** /users/pine/pine3.85.930923/pine/reply.c	Thu Sep 23 04:52:07 1993
--- /users/pine/pine3.85.930927/pine/reply.c	Fri Oct  1 18:29:27 1993
***************
*** 1270,1275 ****
--- 1270,1279 ----
      
      if (env == NULL)		
          return(NULL);
+ /* BJC 931001B: added the next two lines
+ */
+     if (env->message_id == NULL)		
+         return(NULL);
      else {
          sprintf(buffer, "%.100s",  env->message_id);
      }

I have reported this to [email-masked], and Michael Seibel
<[email-masked]> replied saying that this bug will be repaired
in 3.86. 

--
Barry Cornelius                            Durham (091 or +44 91) 374 4717
Information Technology Service,                IT Service Office: 374 2892
University of Durham, Durham.                                Fax: 374 3741
DH1 3LE, UK                           E-mail: [email-masked]

---

From: James Ralston Crawford <[email-masked]>
Date: Thu, 7 Oct 1993 16:11:40 -0400 (EDT)

Excerpts from dl.pine-info: 7-Oct-93 Pine Reply Bug? Rocky
Giannini@paradiso. (1093*)

> were consistently getting core dumps when replying to messages from
> certain sites.  We have since narrowed the problem down.  It appears
> that pine was having trouble replying to messages that did not have a
> Message-Id header.

	Speaking of which, has the bug in Pine which causes it to crash on a
message without a From: header been fixed?  This bug is present in
version 3.03...

-- 
James Ralston Crawford \ [email-masked] \ Systems and Networks [CIS]
University of Pittsburgh \ 600 Epsilon Drive \ Pittsburgh PA 15238-2887
"Computer, you and I need to have a little talk."  - O'Brien, ST:DS9

---

From: David L Miller <[email-masked]>
Date: Thu, 7 Oct 1993 13:27:33 -0700 (PDT)

Yes, that is fixed.